Bug 132799

Summary:

Clean up MainThreadTask

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

132800

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2014-05-10 23:19:45 PDT

Clean up MainThreadTask

Comment 1 Zan Dobersek 2014-05-10 23:25:17 PDT

Created attachment 231252 [details]
Patch

Comment 2 WebKit Commit Bot 2014-05-10 23:26:46 PDT

Attachment 231252 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/MainThreadTask.h:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/MainThreadTask.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Darin Adler 2014-05-11 11:14:03 PDT

Comment on attachment 231252 [details]
Patch

A fine refinement. But I suggest we do the cross-thread copying explicitly and use plain old lambdas rather than having this MainThreadTask class at all.

Comment 4 Zan Dobersek 2014-05-12 00:05:27 PDT

Comment on attachment 231252 [details]
Patch

Clearing flags on attachment: 231252

Committed r168611: <http://trac.webkit.org/changeset/168611>

Comment 5 Zan Dobersek 2014-05-12 00:05:34 PDT

All reviewed patches have been landed.  Closing bug.