Bug 132799

Summary: Clean up MainThreadTask
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 132800    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2014-05-10 23:19:45 PDT
Clean up MainThreadTask
Attachments
Patch (26.38 KB, patch)
2014-05-10 23:25 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-05-10 23:25:17 PDT
Created attachment 231252 [details] Patch
WebKit Commit Bot
Comment 2 2014-05-10 23:26:46 PDT
Attachment 231252 [details] did not pass style-queue: ERROR: Source/WebCore/platform/MainThreadTask.h:40: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/MainThreadTask.h:44: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2014-05-11 11:14:03 PDT
Comment on attachment 231252 [details] Patch A fine refinement. But I suggest we do the cross-thread copying explicitly and use plain old lambdas rather than having this MainThreadTask class at all.
Zan Dobersek
Comment 4 2014-05-12 00:05:27 PDT
Comment on attachment 231252 [details] Patch Clearing flags on attachment: 231252 Committed r168611: <http://trac.webkit.org/changeset/168611>
Zan Dobersek
Comment 5 2014-05-12 00:05:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.