Bug 132798

Summary:

Simplify FileThread::Task usage

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

132800

Attachments:

Description	Flags
Patch	none

Description Zan Dobersek 2014-05-10 23:04:55 PDT

Simplify FileThread::Task usage

Comment 1 Zan Dobersek 2014-05-10 23:14:27 PDT

Created attachment 231251 [details]
Patch

Comment 2 WebKit Commit Bot 2014-05-10 23:16:12 PDT

Attachment 231251 [details] did not pass style-queue:


ERROR: Source/WebCore/fileapi/FileThread.h:75:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Darin Adler 2014-05-11 10:53:26 PDT

Comment on attachment 231251 [details]
Patch

This is OK, and a bit of an improvement, but I think we should also be getting rid of CrossThreadCopier entirely and instead just using plain old lambdas with explicit copying of the arguments.

Comment 4 Zan Dobersek 2014-05-12 00:01:52 PDT

Comment on attachment 231251 [details]
Patch

Clearing flags on attachment: 231251

Committed r168610: <http://trac.webkit.org/changeset/168610>

Comment 5 Zan Dobersek 2014-05-12 00:01:59 PDT

All reviewed patches have been landed.  Closing bug.