Bug 132798

Summary: Simplify FileThread::Task usage
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 132800    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2014-05-10 23:04:55 PDT
Simplify FileThread::Task usage
Attachments
Patch (19.31 KB, patch)
2014-05-10 23:14 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-05-10 23:14:27 PDT
Created attachment 231251 [details] Patch
WebKit Commit Bot
Comment 2 2014-05-10 23:16:12 PDT
Attachment 231251 [details] did not pass style-queue: ERROR: Source/WebCore/fileapi/FileThread.h:75: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2014-05-11 10:53:26 PDT
Comment on attachment 231251 [details] Patch This is OK, and a bit of an improvement, but I think we should also be getting rid of CrossThreadCopier entirely and instead just using plain old lambdas with explicit copying of the arguments.
Zan Dobersek
Comment 4 2014-05-12 00:01:52 PDT
Comment on attachment 231251 [details] Patch Clearing flags on attachment: 231251 Committed r168610: <http://trac.webkit.org/changeset/168610>
Zan Dobersek
Comment 5 2014-05-12 00:01:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.