Bug 132798 - Simplify FileThread::Task usage
Summary: Simplify FileThread::Task usage
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
Depends on:
Blocks: 132800
  Show dependency treegraph
Reported: 2014-05-10 23:04 PDT by Zan Dobersek
Modified: 2014-05-12 00:01 PDT (History)
1 user (show)

See Also:

Patch (19.31 KB, patch)
2014-05-10 23:14 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-05-10 23:04:55 PDT
Simplify FileThread::Task usage
Comment 1 Zan Dobersek 2014-05-10 23:14:27 PDT
Created attachment 231251 [details]
Comment 2 WebKit Commit Bot 2014-05-10 23:16:12 PDT
Attachment 231251 [details] did not pass style-queue:

ERROR: Source/WebCore/fileapi/FileThread.h:75:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-05-11 10:53:26 PDT
Comment on attachment 231251 [details]

This is OK, and a bit of an improvement, but I think we should also be getting rid of CrossThreadCopier entirely and instead just using plain old lambdas with explicit copying of the arguments.
Comment 4 Zan Dobersek 2014-05-12 00:01:52 PDT
Comment on attachment 231251 [details]

Clearing flags on attachment: 231251

Committed r168610: <http://trac.webkit.org/changeset/168610>
Comment 5 Zan Dobersek 2014-05-12 00:01:59 PDT
All reviewed patches have been landed.  Closing bug.