Bug 132787

Summary: Headers and footers are not positioned correctly with topContentInset
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, sam, simon.fraser, thorton, tonikitoo
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Beth Dakin 2014-05-10 15:26:44 PDT
Headers and footers are not positioned correctly with topContentInset

<rdar://problem/16641115>
Comment 1 Beth Dakin 2014-05-10 15:34:46 PDT
Created attachment 231238 [details]
Patch
Comment 2 Tim Horton 2014-05-10 15:44:23 PDT
Comment on attachment 231238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231238&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:225
>      return 0;

nullptr these while you're here!
Comment 3 Sam Weinig 2014-05-10 16:04:46 PDT
Comment on attachment 231238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231238&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:224
> +        return renderView->compositor().headerLayer();

LOL.
Comment 4 Beth Dakin 2014-05-11 14:05:19 PDT
Thanks, Tim! http://trac.webkit.org/changeset/168602