Bug 132787 - Headers and footers are not positioned correctly with topContentInset
Summary: Headers and footers are not positioned correctly with topContentInset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-10 15:26 PDT by Beth Dakin
Modified: 2014-05-11 14:05 PDT (History)
13 users (show)

See Also:

Attachments
Patch (13.34 KB, patch)
2014-05-10 15:34 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-05-10 15:26:44 PDT 
Headers and footers are not positioned correctly with topContentInset

<rdar://problem/16641115>
Comment 1 Beth Dakin 2014-05-10 15:34:46 PDT 
Created attachment 231238 [details]
Patch
Comment 2 Tim Horton 2014-05-10 15:44:23 PDT 
Comment on attachment 231238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231238&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:225
>      return 0;

nullptr these while you're here!
Comment 3 Sam Weinig 2014-05-10 16:04:46 PDT 
Comment on attachment 231238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231238&action=review

> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:224
> +        return renderView->compositor().headerLayer();

LOL.
Comment 4 Beth Dakin 2014-05-11 14:05:19 PDT 
Thanks, Tim! http://trac.webkit.org/changeset/168602