Bug 132772

Summary: [Win] Enum type with value zero is compatible with void*, potential cause of crashes.
Product: WebKit Reporter: peavo
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ggaren, jeffrey+webkit, mark.lam, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 132839    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2014-05-10 02:30:08 PDT
Using the MSVC compiler, an instance of an enum type with value zero, is compatible with void* (see bug 132683 for a code example). This has caused crashes on Windows on two occasions (bug 132683, and bug 121001). This patch tries to prevent these type of crashes by using a type with explicit constructors instead of void*.
Attachments
Patch (19.46 KB, patch)
2014-05-10 02:39 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (20.76 KB, patch)
2014-05-13 12:48 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-05-10 02:39:21 PDT
Created attachment 231223 [details] Patch
Geoffrey Garen
Comment 2 2014-05-10 12:58:01 PDT
Comment on attachment 231223 [details] Patch r=me
peavo
Comment 3 2014-05-10 13:06:53 PDT
(In reply to comment #2) > (From update of attachment 231223 [details]) > r=me Thanks!
peavo
Comment 4 2014-05-12 11:56:38 PDT
cq+? ;)
WebKit Commit Bot
Comment 5 2014-05-12 13:42:53 PDT
Comment on attachment 231223 [details] Patch Clearing flags on attachment: 231223 Committed r168642: <http://trac.webkit.org/changeset/168642>
WebKit Commit Bot
Comment 6 2014-05-12 13:42:57 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2014-05-12 15:12:22 PDT
Re-opened since this is blocked by bug 132839
peavo
Comment 8 2014-05-13 12:48:41 PDT
Created attachment 231401 [details] Patch
peavo
Comment 9 2014-05-13 12:50:59 PDT
(In reply to comment #8) > Created an attachment (id=231401) [details] > Patch Sorry for the inconvenience. Updated patch.
Geoffrey Garen
Comment 10 2014-05-13 12:59:20 PDT
Comment on attachment 231401 [details] Patch Let's give this another go.
peavo
Comment 11 2014-05-13 13:24:49 PDT
(In reply to comment #10) > (From update of attachment 231401 [details]) > Let's give this another go. Thanks :)
WebKit Commit Bot
Comment 12 2014-05-13 13:57:39 PDT
Comment on attachment 231401 [details] Patch Clearing flags on attachment: 231401 Committed r168729: <http://trac.webkit.org/changeset/168729>
WebKit Commit Bot
Comment 13 2014-05-13 13:57:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.