Bug 132768

Summary:

[iOS][WK2] Fix bugs exposed by r168556

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2014-05-09 21:46:18 PDT

[iOS][WK2] Fix bugs exposed by r168556

Comment 1 Benjamin Poulain 2014-05-09 21:52:09 PDT

Created attachment 231213 [details]
Patch

Comment 2 Ryosuke Niwa 2014-05-09 22:02:15 PDT

Comment on attachment 231213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231213&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1896
> +    return fabs(a - b) < std::numeric_limits<float>::epsilon();

It'll be nice if we could share this with e.g. FloatSize.cpp but I guess we can do that in a separate patch.

Comment 3 Benjamin Poulain 2014-05-09 22:14:48 PDT

Comment on attachment 231213 [details]
Patch

Clearing flags on attachment: 231213

Committed r168572: <http://trac.webkit.org/changeset/168572>

Comment 4 Benjamin Poulain 2014-05-09 22:14:51 PDT

All reviewed patches have been landed.  Closing bug.