WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132768
[iOS][WK2] Fix bugs exposed by
r168556
https://bugs.webkit.org/show_bug.cgi?id=132768
Summary
[iOS][WK2] Fix bugs exposed by r168556
Benjamin Poulain
Reported
2014-05-09 21:46:18 PDT
[iOS][WK2] Fix bugs exposed by
r168556
Attachments
Patch
(3.46 KB, patch)
2014-05-09 21:52 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-05-09 21:52:09 PDT
Created
attachment 231213
[details]
Patch
Ryosuke Niwa
Comment 2
2014-05-09 22:02:15 PDT
Comment on
attachment 231213
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=231213&action=review
> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1896 > + return fabs(a - b) < std::numeric_limits<float>::epsilon();
It'll be nice if we could share this with e.g. FloatSize.cpp but I guess we can do that in a separate patch.
Benjamin Poulain
Comment 3
2014-05-09 22:14:48 PDT
Comment on
attachment 231213
[details]
Patch Clearing flags on attachment: 231213 Committed
r168572
: <
http://trac.webkit.org/changeset/168572
>
Benjamin Poulain
Comment 4
2014-05-09 22:14:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug