Summary: | Update availability macros | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | mitz | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2014-05-09 18:13:28 PDT
Created attachment 231203 [details]
Patch
Comment on attachment 231203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231203&action=review > Source/WebKit2/mac/rewrite-availability-macros.sh:2 > +set -x Please don’t do this. Comment on attachment 231203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231203&action=review The script phases should run when installing headers, and I think the WebKit target currently doesn’t have INSTALLHDRS_SCRIPT_PHASE set to YES. You’ll need to add that to WebKit.xcconfig. > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:7663 > + 1A1D2115191D96380001619F /* Rewrite Availability Macros In Framework Headers */, “in” > Source/WebKit2/mac/rewrite-availability-macros.sh:3 > + You should check the build action here and only do this in build, install and installhdrs. Committed r168566: <http://trac.webkit.org/changeset/168566> |