RESOLVED FIXED 132763
Update availability macros 
https://bugs.webkit.org/show_bug.cgi?id=132763
Summary Update availability macros
Anders Carlsson
Reported 2014-05-09 18:13:28 PDT
Update availability macros
Attachments
Patch (45.64 KB, patch)
2014-05-09 18:14 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-05-09 18:14:46 PDT
Created attachment 231203 [details] Patch
mitz
Comment 2 2014-05-09 18:24:05 PDT
Comment on attachment 231203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231203&action=review > Source/WebKit2/mac/rewrite-availability-macros.sh:2 > +set -x Please don’t do this.
mitz
Comment 3 2014-05-09 18:32:07 PDT
Comment on attachment 231203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231203&action=review The script phases should run when installing headers, and I think the WebKit target currently doesn’t have INSTALLHDRS_SCRIPT_PHASE set to YES. You’ll need to add that to WebKit.xcconfig. > Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:7663 > + 1A1D2115191D96380001619F /* Rewrite Availability Macros In Framework Headers */, “in” > Source/WebKit2/mac/rewrite-availability-macros.sh:3 > + You should check the build action here and only do this in build, install and installhdrs.
Anders Carlsson
Comment 4 2014-05-09 18:49:52 PDT
Committed r168566: <http://trac.webkit.org/changeset/168566>
Note You need to log in before you can comment on or make changes to this bug.