Summary: | com.apple.iphonesimulator.startSession needs to pass “runtimeIdentifier” | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Farler <dfarler> | ||||
Component: | Tools / Tests | Assignee: | David Farler <dfarler> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ddkilzer | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | All | ||||||
Attachments: |
|
Description
David Farler
2014-05-08 17:23:30 PDT
Created attachment 231118 [details]
Patch
Comment on attachment 231118 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231118&action=review r=me > Tools/DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:204 > - my $userInfo = NSMutableDictionary->dictionaryWithCapacity_(4); > - for my $property (qw(applicationArguments applicationEnvironment applicationIdentifier applicationPath deviceFamily deviceInfo productType sessionOwner sessionUUID sdkRoot version waitForDebugger)) { > - if (exists $dict->{$property}) { > - my $key = NSString->stringWithCString_($property); > - my $value = $dict->{$property}; > - $userInfo->setObject_forKey_($value, $key); > - } > + my $userInfo = NSMutableDictionary->dictionaryWithCapacity_(scalar(keys($dict)) + 1); > + foreach my $key (keys($dict)) { > + $userInfo->setObject_forKey_($dict->{$key}, $key); Nice! Comment on attachment 231118 [details] Patch Clearing flags on attachment: 231118 Committed r168547: <http://trac.webkit.org/changeset/168547> All reviewed patches have been landed. Closing bug. |