Summary: | [EME] Call suspendIfNeeded() in the MediaKeySession constructor to avoid an ASSERT. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, philipj, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jer Noble
2014-05-08 16:19:38 PDT
Created attachment 231108 [details]
Patch
Comment on attachment 231108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44 > + session->suspendIfNeeded(); Why not do this in the constructor? (In reply to comment #2) > (From update of attachment 231108 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231108&action=review > > > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:44 > > + session->suspendIfNeeded(); > > Why not do this in the constructor? We could, but it's generally a bad idea to call virtual functions in the constructor. Comment on attachment 231108 [details] Patch Clearing flags on attachment: 231108 Committed r168533: <http://trac.webkit.org/changeset/168533> All reviewed patches have been landed. Closing bug. |