Bug 132698

Summary: [MSE][Mac] Move AVStreamDataParser off-main-thread.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, calvaris, cgarcia, commit-queue, eric.carlson, glenn, gustavo, menard, mrobinson, philipj, pnormand, sergio, vjaquez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 132710    
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing. none

Description Jer Noble 2014-05-08 12:17:14 PDT 
[MSE][Mac] Move AVStreamDataParser off-main-thread.
Comment 1 Jer Noble 2014-05-08 12:25:07 PDT 
Created attachment 231089 [details]
Patch
Comment 2 Eric Carlson 2014-05-08 12:38:46 PDT 
Comment on attachment 231089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231089&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:496
> +    RefPtr<SourceBufferPrivateAVFObjC> strongThis(this);

Nit: why do you initialize this RefPtr with constructor syntax and the previous ones with assignment?
Comment 3 Jer Noble 2014-05-08 15:15:38 PDT 
Created attachment 231103 [details]
Patch for landing.
Comment 4 Jer Noble 2014-05-08 15:30:01 PDT 
(In reply to comment #2)
> (From update of attachment 231089 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231089&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:496
> > +    RefPtr<SourceBufferPrivateAVFObjC> strongThis(this);
> 
> Nit: why do you initialize this RefPtr with constructor syntax and the previous ones with assignment?

No good reason.  Fixed that, and updated the patch so as to not break GTK.
Comment 5 Jer Noble 2014-05-08 17:22:02 PDT 
Committed r168508: <http://trac.webkit.org/changeset/168508>