Bug 132694

Summary: Wrap a new class definition with __has_include()
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch v1 thorton: review+

Description Brady Eidson 2014-05-08 11:26:28 PDT
Wrap a new class definition with __has_include(), as the include might be on some systems.

<rdar://problem/16852395>
Comment 1 Brady Eidson 2014-05-08 11:29:02 PDT
Created attachment 231082 [details]
Patch v1
Comment 2 Tim Horton 2014-05-08 11:30:08 PDT
Comment on attachment 231082 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231082&action=review

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:58
>  // FIXME: We should properly disable code that interacts with NSItemProvider/NSSharingServicePicker in 32-bit.

we may have done this?
Comment 3 Brady Eidson 2014-05-08 11:34:26 PDT
(In reply to comment #2)
> (From update of attachment 231082 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231082&action=review
> 
> > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:58
> >  // FIXME: We should properly disable code that interacts with NSItemProvider/NSSharingServicePicker in 32-bit.
> 
> we may have done this?

We disabled some code.  I haven't looked to make sure we did it "properly"
Comment 4 Brady Eidson 2014-05-08 12:16:19 PDT
http://trac.webkit.org/changeset/168482