Bug 132682

Summary: [iOS WebKit2] Can't activate text fields on Facebook
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: benjamin, enrica
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
patch 2 enrica: review+

Description Antti Koivisto 2014-05-08 07:55:25 PDT
Content change observer fails to complete
Comment 1 Antti Koivisto 2014-05-08 07:55:58 PDT
Comment 2 Antti Koivisto 2014-05-08 08:14:57 PDT
Created attachment 231067 [details]
Comment 3 Antti Koivisto 2014-05-08 09:10:17 PDT
Created attachment 231072 [details]
patch 2

The same patch without changing CheckForVisibilityChangeOnRecalcStyle to match the old behavior. This is not needed to fix Facebook and the new behavior is arguably more sensible than the old one.
Comment 4 Antti Koivisto 2014-05-08 09:11:03 PDT
If it is needed it is better done separately.
Comment 5 Enrica Casucci 2014-05-08 09:23:10 PDT
Comment on attachment 231072 [details]
patch 2

Looks good!
Comment 6 Antti Koivisto 2014-05-08 09:43:31 PDT
Comment 7 Benjamin Poulain 2014-05-08 14:53:42 PDT
Comment on attachment 231072 [details]
patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=231072&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.h:1199
> +    RefPtr<WebCore::Node> m_pendingSyntheticClickNode;
> +    WebCore::FloatPoint m_pendingSyntheticClickLocation;

You should put those next to m_potentialTapNode && m_potentialTapLocation