Bug 132676

Summary:

Remove CSS_STICKY_POSITION guards

Product:

WebKit

Reporter:

Tibor Mészáros <mtiborinf>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, gyuyoung.kim, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none
Patch v2	ossy: review-, ossy: commit-queue-
Patch v3	none

Tibor Mészáros

Reported 2014-05-08 02:12:51 PDT

It's a small feature that everyone has enabled, so we should get rid of the guard? Reference to a discussion about it: https://bugs.webkit.org/show_bug.cgi?id=129793

Attachments
Patch v1 (50.10 KB, patch) 2014-05-08 02:20 PDT, Tibor Mészáros	no flags	Details Formatted Diff Diff
Patch v2 (50.03 KB, patch) 2014-05-08 04:20 PDT, Tibor Mészáros	ossy: review- ossy: commit-queue-	Details Formatted Diff Diff
Patch v3 (50.02 KB, patch) 2014-05-13 04:49 PDT, Tibor Mészáros	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tibor Mészáros

Comment 1 2014-05-08 02:20:07 PDT

Created attachment 231054 [details] Patch v1 CSS_STICKY_POSITION guard removed

WebKit Commit Bot

Comment 2 2014-05-08 02:21:41 PDT

Attachment 231054 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tibor Mészáros

Comment 3 2014-05-08 04:20:07 PDT

Created attachment 231059 [details] Patch v2 fixed style

Csaba Osztrogonác

Comment 4 2014-05-08 06:22:34 PDT

Comment on attachment 231059 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=231059&action=review > ChangeLog:4 > + Remove CSS_STICKY_POSITION > + https://bugs.webkit.org/show_bug.cgi?id=132676 This patch doens't remove CSS_STICKY_POSITION, but the guards only.

Tibor Mészáros

Comment 5 2014-05-13 04:49:02 PDT

Created attachment 231368 [details] Patch v3 The bug/patch name has been changed.

WebKit Commit Bot

Comment 6 2014-05-14 09:45:25 PDT

Comment on attachment 231368 [details] Patch v3 Clearing flags on attachment: 231368 Committed r168839: <http://trac.webkit.org/changeset/168839>

WebKit Commit Bot

Comment 7 2014-05-14 09:45:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.