Bug 132672

Summary: [CSS Regions] 1-2% performance regression in html5-full-render after r168286
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: Layout and RenderingAssignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128243    
Attachments:
Description Flags
Patch
none
Patch that applies none

Description Andrei Bucur 2014-05-08 01:13:18 PDT 
After new-multi was enabled the RenderFlowThread code path started affecting some of the performance tests (some have multi-column elements). Investigate this regression and find a fix for it.
Comment 1 Andrei Bucur 2014-05-08 01:14:02 PDT 
The changeset to blame: http://trac.webkit.org/changeset/168286
Comment 2 Andrei Bucur 2014-05-09 02:00:10 PDT 
Created attachment 231135 [details]
Patch
Comment 3 Andrei Bucur 2014-05-09 02:05:55 PDT 
Created attachment 231136 [details]
Patch that applies
Comment 4 Mihnea Ovidenie 2014-05-09 04:03:08 PDT 
Comment on attachment 231136 [details]
Patch that applies

r=me. Instead of testing the single region case directly, it may be a good idea to have a helper function.
Comment 5 Andrei Bucur 2014-05-09 08:45:14 PDT 
I don't suspect I'll use this condition in more places. I'm kinda skeptical having a function hasOneRegion actually brings value.

If this is an optimization that can be applied in other places as well, I'll create that helper function.
Comment 6 WebKit Commit Bot 2014-05-09 09:16:28 PDT 
Comment on attachment 231136 [details]
Patch that applies

Clearing flags on attachment: 231136

Committed r168534: <http://trac.webkit.org/changeset/168534>
Comment 7 WebKit Commit Bot 2014-05-09 09:16:32 PDT 
All reviewed patches have been landed.  Closing bug.