Bug 132672

Summary: [CSS Regions] 1-2% performance regression in html5-full-render after r168286
Product: WebKit Reporter: Andrei Bucur <abucur>
Component: Layout and RenderingAssignee: Andrei Bucur <abucur>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128243    
Attachments:
Description Flags
Patch
none
Patch that applies none

Andrei Bucur
Reported 2014-05-08 01:13:18 PDT
After new-multi was enabled the RenderFlowThread code path started affecting some of the performance tests (some have multi-column elements). Investigate this regression and find a fix for it.
Attachments
Patch (4.54 KB, patch)
2014-05-09 02:00 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Patch that applies (4.54 KB, patch)
2014-05-09 02:05 PDT, Andrei Bucur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrei Bucur
Comment 1 2014-05-08 01:14:02 PDT
The changeset to blame: http://trac.webkit.org/changeset/168286
Andrei Bucur
Comment 2 2014-05-09 02:00:10 PDT
Created attachment 231135 [details] Patch
Andrei Bucur
Comment 3 2014-05-09 02:05:55 PDT
Created attachment 231136 [details] Patch that applies
Mihnea Ovidenie
Comment 4 2014-05-09 04:03:08 PDT
Comment on attachment 231136 [details] Patch that applies r=me. Instead of testing the single region case directly, it may be a good idea to have a helper function.
Andrei Bucur
Comment 5 2014-05-09 08:45:14 PDT
I don't suspect I'll use this condition in more places. I'm kinda skeptical having a function hasOneRegion actually brings value. If this is an optimization that can be applied in other places as well, I'll create that helper function.
WebKit Commit Bot
Comment 6 2014-05-09 09:16:28 PDT
Comment on attachment 231136 [details] Patch that applies Clearing flags on attachment: 231136 Committed r168534: <http://trac.webkit.org/changeset/168534>
WebKit Commit Bot
Comment 7 2014-05-09 09:16:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.