Bug 132663

Summary: Image menu is offset by the amount the view is scrolled
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch v1 thorton: review+

Brady Eidson
Reported 2014-05-07 14:06:30 PDT
Image menu is offset by the amount the view is scrolled <rdar://problem/16818966>
Attachments
Patch v1 (1.51 KB, patch)
2014-05-07 14:08 PDT, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-05-07 14:08:07 PDT
Created attachment 231021 [details] Patch v1
Tim Horton
Comment 2 2014-05-07 14:09:50 PDT
Comment on attachment 231021 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231021&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:433 > IntPoint point = frameView->contentsToRootView(page->contextMenuController().hitTestResult().roundedPointInInnerNodeFrame()); > + point.moveBy(frameView->scrollPosition()); I think you want contentsToWindow instead of contentsToRootView, right? And then you won't need to remove the scrollPosition yourself.
Brady Eidson
Comment 3 2014-05-07 14:18:59 PDT
http://trac.webkit.org/changeset/168438
Note You need to log in before you can comment on or make changes to this bug.