Bug 132663 - Image menu is offset by the amount the view is scrolled
Summary: Image menu is offset by the amount the view is scrolled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-07 14:06 PDT by Brady Eidson
Modified: 2014-05-07 14:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (1.51 KB, patch)
2014-05-07 14:08 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-05-07 14:06:30 PDT 
Image menu is offset by the amount the view is scrolled

<rdar://problem/16818966>
Comment 1 Brady Eidson 2014-05-07 14:08:07 PDT 
Created attachment 231021 [details]
Patch v1
Comment 2 Tim Horton 2014-05-07 14:09:50 PDT 
Comment on attachment 231021 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=231021&action=review

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:433
>      IntPoint point = frameView->contentsToRootView(page->contextMenuController().hitTestResult().roundedPointInInnerNodeFrame());
> +    point.moveBy(frameView->scrollPosition());

I think you want contentsToWindow instead of contentsToRootView, right? And then you won't need to remove the scrollPosition yourself.
Comment 3 Brady Eidson 2014-05-07 14:18:59 PDT 
http://trac.webkit.org/changeset/168438