Bug 132647

Summary:

Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in svg/

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

SVG

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, d-r, fmalita, gyuyoung.kim, kling, koivisto, pdr, schenney, sergio, thorton, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

130185

Attachments:

Description	Flags
Patch	darin: review+

Description Sergio Villar Senin 2014-05-07 05:02:16 PDT

Summary says it all

Comment 1 Sergio Villar Senin 2014-05-07 07:48:15 PDT

Created attachment 230997 [details]
Patch

Comment 2 Darin Adler 2014-05-07 18:00:47 PDT

Comment on attachment 230997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230997&action=review

Seems like there is an inefficient pattern here of all these sets, but thanks for modernizing the idiom at least.

> Source/WebCore/svg/SVGUseElement.cpp:60
> +#include <wtf/NeverDestroyed.h>

This should be up above with the #includes (at the bottom of them), not here down below the commented-out #defines.

Comment 3 Sergio Villar Senin 2014-05-08 03:59:55 PDT

Committed r168469: <http://trac.webkit.org/changeset/168469>