Summary: | [Mac, iOS] Add source application accounting to AVURLAsset. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, philipj, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jer Noble
2014-05-06 19:07:59 PDT
Created attachment 231088 [details]
Patch
Comment on attachment 231088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review > Source/WebCore/ChangeLog:8 > + Property account for the application responisble for data loading by passing the source Nit: Do you mean "Properly"? > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154 > +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *) Should you use SOFT_LINK_POINTER_OPTIONAL for older systems? (In reply to comment #2) > (From update of attachment 231088 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review > > > Source/WebCore/ChangeLog:8 > > + Property account for the application responisble for data loading by passing the source > > Nit: Do you mean "Properly"? I do! Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154 > > +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *) > > Should you use SOFT_LINK_POINTER_OPTIONAL for older systems? Good catch. I'll do this and check that it's non-null before adding it to the options dictionary. I'll upload a new patch to address the other platform build errors. Created attachment 231111 [details]
Patch for landing.
Committed r168512: <http://trac.webkit.org/changeset/168512> |