Bug 132637

Summary: [Mac, iOS] Add source application accounting to AVURLAsset.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+
Patch for landing. none

Description Jer Noble 2014-05-06 19:07:59 PDT
[Mac, iOS] Add source application accounting to AVURLAsset.
Comment 1 Jer Noble 2014-05-08 12:06:58 PDT
Created attachment 231088 [details]
Patch
Comment 2 Eric Carlson 2014-05-08 12:24:24 PDT
Comment on attachment 231088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review

> Source/WebCore/ChangeLog:8
> +        Property account for the application responisble for data loading by passing the source

Nit: Do you mean "Properly"?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154
> +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *)

Should you use SOFT_LINK_POINTER_OPTIONAL for older systems?
Comment 3 Jer Noble 2014-05-08 16:37:18 PDT
(In reply to comment #2)
> (From update of attachment 231088 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=231088&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Property account for the application responisble for data loading by passing the source
> 
> Nit: Do you mean "Properly"?

I do!

Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:154
> > +SOFT_LINK_POINTER(AVFoundation, AVURLAssetClientBundleIdentifierKey, NSString *)
> 
> Should you use SOFT_LINK_POINTER_OPTIONAL for older systems?

Good catch. I'll do this and check that it's non-null before adding it to the options dictionary.

I'll upload a new patch to address the other platform build errors.
Comment 4 Jer Noble 2014-05-08 16:40:11 PDT
Created attachment 231111 [details]
Patch for landing.
Comment 5 Jer Noble 2014-05-08 18:07:26 PDT
Committed r168512: <http://trac.webkit.org/changeset/168512>