| Summary: | Do the bmalloc. | ||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||||||||||||||||||||||||||
| Component: | Platform | Assignee: | Andreas Kling <kling> | ||||||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | benjamin, cmarcelo, commit-queue, ggaren, kling, laszlo.gombos, ossy | ||||||||||||||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||
|
Description
Andreas Kling
2014-05-06 15:19:26 PDT
Created attachment 230938 [details]
Snack for EWS
Wooot! :) Created attachment 230945 [details]
Snack Fighter II: World Warrior
Created attachment 230958 [details]
Snackcraft III: The Frozen Throne
Created attachment 231231 [details]
Patch
Giving this another try, since I think the bots must be crazy. (In reply to comment #6) > Giving this another try, since I think the bots must be crazy. I this the bots aren't crazy, but this patch made SVG tests crash: https://webkit-queues.appspot.com/patch/231231 Comment on attachment 231231 [details]
Patch
r- not to force EWS bots run in an infinite loop.
Created attachment 236622 [details]
Patch
Comment on attachment 236622 [details]
Patch
If it fits, etc.
Tests are still crashing on EWS. Comment on attachment 236622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236622&action=review > Source/WTF/wtf/FastMalloc.cpp:104 > +#if (PLATFORM(MAC) || PLATFORM(IOS)) && (CPU(X86_64) || CPU(ARM64)) PLATFORM(COCOA) ! Created attachment 236770 [details]
Patch
Not really for review. Trying to reproduce EWS failure. Created attachment 236771 [details]
Patch
Created attachment 236823 [details]
Patch
Created attachment 236879 [details]
Patch
Created attachment 236893 [details]
Patch
Created attachment 236905 [details]
Patch
Created attachment 237582 [details]
Patch
Perhaps, with the fix for bug 136469, this will pass EWS now. Created attachment 237644 [details]
Patch
Comment on attachment 237644 [details]
Patch
r=me
Committed r173313: <http://trac.webkit.org/changeset/173313> Reopening to attach new patch. Created attachment 237905 [details]
Patch
Created attachment 237912 [details]
Patch
Created attachment 237987 [details]
Patch
Committed r173540: <http://trac.webkit.org/changeset/173540> Rolled out in <http://trac.webkit.org/changeset/r173565>. Created attachment 238603 [details]
Patch
Committed r173935: <http://trac.webkit.org/changeset/173935> Results from perf bots: OSMemoryTesting/Snap2FinishedLoadingPost:Allocations:Total: 0% (no regression) PLT: 5% DOM/GetElement: 42.84% jslib-attr-jquery: 18.1% dromaeo-object-string: 13.3% dom-modify: 12.3% cssquery-jquery: 5% cssquery-prototype: 4.8% cssquery-dojo: 3.8% dromaeo-object-array: 3.4% jslib-style-jquery: 3.2% DYEB: 2.4% Parser/HTML5-8266-FullRender: 4% Parser/HTML5-8266-ParseOnly: 5.6% css-parser-yui: 10.2% Parser/html-parser: 6.5% Parser/textarea-parsing: 11.22% Layout/floats_100_100: 7.22% Layout/floats_100_100_nested: 9.32% Layout/floats_20_100: 11.42% Layout/floats_20_100_nested: 13.86% Layout/layers_overlap_2d: 6.69% Layout/auto-grid-lots-of-data: 4.3% Layout/chapter-reflow-once-random: 3.8% Layout/fixed-grid-lots-of-data: 5.92% Interactive/window-resize: 2% Animation/balls:FrameRate: 4% DOM/CloneNodes: 13.93% DOM/DOMDivWalk: 10.7% DOM/GetElement: 42.84% DOM/ModifyAttribute: 8.7% obamanotbad.jpg MallocBench result vs TCMalloc: geometric mean speedup: 2.11x faster biggest speedup (list_allocate): 4.09x faster |