| Summary: | AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||||
| Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, commit-queue, dmazzoni, esprehn+autocc, glenn, jcraig, jdiggs, kondapallykalyan, mario, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
chris fleizach
2014-05-06 13:50:52 PDT
Created attachment 230929 [details]
patch
Attachment 230929 [details] did not pass style-queue:
ERROR: Source/WebCore/rendering/RenderText.h:245: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 230930 [details]
patch
Comment on attachment 230930 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230930&action=review Looks good. > Tools/DumpRenderTree/AccessibilityUIElement.cpp:437 > + return JSValueMakeBoolean(context, false); Did this sneak in accidentally? I might be missing something, but I don't see an equality test that would need this. Created attachment 230935 [details]
patch
Comment on attachment 230935 [details] patch Clearing flags on attachment: 230935 Committed r168427: <http://trac.webkit.org/changeset/168427> All reviewed patches have been landed. Closing bug. |