Bug 132622

Summary: AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, commit-queue, dmazzoni, esprehn+autocc, glenn, jcraig, jdiggs, kondapallykalyan, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

chris fleizach
Reported 2014-05-06 13:50:52 PDT
The AXSelectTextWithCriteria mechanism needs to support capitalize, lowercase and uppercase to be complete <rdar://problem/16462451>
Attachments
patch (26.10 KB, patch)
2014-05-06 13:52 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (26.09 KB, patch)
2014-05-06 13:56 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (25.82 KB, patch)
2014-05-06 14:58 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2014-05-06 13:52:40 PDT
Created attachment 230929 [details] patch
WebKit Commit Bot
Comment 2 2014-05-06 13:55:34 PDT
Attachment 230929 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderText.h:245: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
chris fleizach
Comment 3 2014-05-06 13:56:36 PDT
Created attachment 230930 [details] patch
Samuel White
Comment 4 2014-05-06 14:55:51 PDT
Comment on attachment 230930 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230930&action=review Looks good. > Tools/DumpRenderTree/AccessibilityUIElement.cpp:437 > + return JSValueMakeBoolean(context, false); Did this sneak in accidentally? I might be missing something, but I don't see an equality test that would need this.
chris fleizach
Comment 5 2014-05-06 14:58:30 PDT
Created attachment 230935 [details] patch
WebKit Commit Bot
Comment 6 2014-05-07 09:18:16 PDT
Comment on attachment 230935 [details] patch Clearing flags on attachment: 230935 Committed r168427: <http://trac.webkit.org/changeset/168427>
WebKit Commit Bot
Comment 7 2014-05-07 09:18:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.