Bug 132617

Summary: Eliminate BlobStorageData
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, commit-queue, danw, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
andersca: review+
patch for landing none

Alexey Proskuryakov
Reported 2014-05-06 10:47:19 PDT
BlobStorageData is an entirely useless wrapper around BlobData that confuses ownership.
Attachments
proposed patch (28.39 KB, patch)
2014-05-06 10:51 PDT, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
patch for landing (28.39 KB, patch)
2014-05-06 11:59 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-05-06 10:51:00 PDT
Created attachment 230919 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-05-06 10:52:41 PDT
Attachment 230919 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "blobData" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2014-05-06 11:59:22 PDT
Created attachment 230921 [details] patch for landing
WebKit Commit Bot
Comment 4 2014-05-06 15:11:36 PDT
Comment on attachment 230921 [details] patch for landing Clearing flags on attachment: 230921 Committed r168382: <http://trac.webkit.org/changeset/168382>
WebKit Commit Bot
Comment 5 2014-05-06 15:11:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.