Summary: | Eliminate BlobStorageData | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, cdumez, cgarcia, commit-queue, danw, gustavo, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-05-06 10:47:19 PDT
Created attachment 230919 [details]
proposed patch
Attachment 230919 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "blobData" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 4 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 230921 [details]
patch for landing
Comment on attachment 230921 [details] patch for landing Clearing flags on attachment: 230921 Committed r168382: <http://trac.webkit.org/changeset/168382> All reviewed patches have been landed. Closing bug. |