Bug 132616

Summary: ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Andreas Kling
Reported 2014-05-06 10:42:48 PDT
ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
Attachments
Patch (2.81 KB, patch)
2014-05-06 10:43 PDT, Andreas Kling 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-05-06 10:43:17 PDT
Created attachment 230918 [details] Patch
Geoffrey Garen
Comment 2 2014-05-06 10:46:48 PDT
Comment on attachment 230918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230918&action=review r=me > Source/WebCore/dom/ContainerNode.h:310 > + Vector<RefPtr<Node>> m_childNodes; // Lazily instantiated. I would call this "m_snapshot" -- or call the bool above "m_hasChildNodes". We want the flag to share a name with what it flags. Otherwise, the pickles will not fly over the relish.
Andreas Kling
Comment 3 2014-05-06 15:14:15 PDT
Committed r168383: <http://trac.webkit.org/changeset/168383>
Note You need to log in before you can comment on or make changes to this bug.