Bug 132616

Summary:

ChildNodesLazySnapshot::m_childNodes needs two heap allocations.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

DOM

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, kangil.han, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ggaren: review+

Description Andreas Kling 2014-05-06 10:42:48 PDT

ChildNodesLazySnapshot::m_childNodes needs two heap allocations.

Comment 1 Andreas Kling 2014-05-06 10:43:17 PDT

Created attachment 230918 [details]
Patch

Comment 2 Geoffrey Garen 2014-05-06 10:46:48 PDT

Comment on attachment 230918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230918&action=review

r=me

> Source/WebCore/dom/ContainerNode.h:310
> +    Vector<RefPtr<Node>> m_childNodes; // Lazily instantiated.

I would call this "m_snapshot" -- or call the bool above "m_hasChildNodes". We want the flag to share a name with what it flags. Otherwise, the pickles will not fly over the relish.

Comment 3 Andreas Kling 2014-05-06 15:14:15 PDT

Committed r168383: <http://trac.webkit.org/changeset/168383>