| Summary: | URI doesn't get updated for cached 301 redirects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mschiffer | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
mschiffer
2014-05-06 10:07:55 PDT
I've now further debugged this. The WebKitWebView never gets a load-changed signal with WEBKIT_LOAD_REDIRECTED for cached redirects, as it would normally be triggered by WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad(), which is called by ResourceLoader::willSendRequest(), but the ResourceLoader is not active for cached requests. I think to fix this, it'd be necessary to move the WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad() call to CachedRawResource or DocumentLoader. Does this make sense? I don't know the code very well, but if you agree with my analysis, I can try cooking up a patch. Created attachment 231159 [details]
Bugfix
This patch fixes the problem for me, both in Epiphany and my own application.
Hi, it's been more that a week since I reported this bug *and* provided a patch. Anyone looked at it yet? It'd be really nice if I could a least get a reaction on my bug report, which is now over a month old. Pinging again. Anyone willing to look at this bug report? It's been two months since I provided a patch... I can't reproduce this bug with the current version (webkit2-gtk3 2.4.4) anymore, so I guess it's been fixed. |