Bug 132587

Summary: remove unnecessary notImplemented.h inclusions
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, andersca, apinheiro, cfleizach, commit-queue, dino, dmazzoni, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, hta, japhet, jcraig, jdiggs, jer.noble, jfernandez, jsbell, kondapallykalyan, mario, noam, ossy, philipj, rego, roger_fong, samuel_white, sergio, svillar, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2014-05-05 16:50:30 PDT
Things have been implemented. If there's no notImplemented() in a file, then we shouldn't include notImplemented.h.
Attachments
Patch (15.95 KB, patch)
2014-05-05 16:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-05-05 16:55:58 PDT
Created attachment 230868 [details] Patch
WebKit Commit Bot
Comment 2 2014-05-06 11:05:23 PDT
Comment on attachment 230868 [details] Patch Clearing flags on attachment: 230868 Committed r168367: <http://trac.webkit.org/changeset/168367>
WebKit Commit Bot
Comment 3 2014-05-06 11:05:37 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2014-05-06 11:33:01 PDT
(In reply to comment #2) > (From update of attachment 230868 [details]) > Clearing flags on attachment: 230868 > > Committed r168367: <http://trac.webkit.org/changeset/168367> It broke the debug build: /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/platform/NotImplemented.cpp:34:16: error: no previous prototype for function 'notImplementedLoggingChannel' [-Werror,-Wmissing-prototypes] WTFLogChannel* notImplementedLoggingChannel()
Note You need to log in before you can comment on or make changes to this bug.