Bug 132583

Summary: Need a delegate that informs the UI process when the page's pin state changes
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, cmarcelo, commit-queue, jamesr, luiz, tonikitoo
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+
Patch that bumps version of UIClient andersca: review+

Beth Dakin
Reported 2014-05-05 14:54:32 PDT
Need a delegate that informs the UI process when the page's pin state changes <rdar://problem/16806231>
Attachments
Patch (9.62 KB, patch)
2014-05-05 15:22 PDT, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
Patch that bumps version of UIClient (13.88 KB, patch)
2014-05-05 15:53 PDT, Beth Dakin 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-05-05 15:22:28 PDT
Created attachment 230859 [details] Patch
Beth Dakin
Comment 2 2014-05-05 15:53:36 PDT
Created attachment 230864 [details] Patch that bumps version of UIClient Thanks, Sam! Anders says I need to bump the version of the UIClient, so here is a new patch.
Anders Carlsson
Comment 3 2014-05-05 15:56:58 PDT
Comment on attachment 230864 [details] Patch that bumps version of UIClient View in context: https://bugs.webkit.org/attachment.cgi?id=230864&action=review > Source/WebKit2/UIProcess/API/APIUIClient.h:136 > + virtual void pinnedStateDidChange(WebKit::WebPageProxy*) { } This can take a WebPageProxy&.
Beth Dakin
Comment 4 2014-05-05 16:15:47 PDT
(In reply to comment #3) > (From update of attachment 230864 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230864&action=review > > > Source/WebKit2/UIProcess/API/APIUIClient.h:136 > > + virtual void pinnedStateDidChange(WebKit::WebPageProxy*) { } > > This can take a WebPageProxy&. I changed it to that! http://trac.webkit.org/changeset/168325
Note You need to log in before you can comment on or make changes to this bug.