Bug 132583 - Need a delegate that informs the UI process when the page's pin state changes
Summary: Need a delegate that informs the UI process when the page's pin state changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-05 14:54 PDT by Beth Dakin
Modified: 2014-05-05 16:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.62 KB, patch)
2014-05-05 15:22 PDT, Beth Dakin 		sam: review+
Details | Formatted Diff | Diff
Patch that bumps version of UIClient (13.88 KB, patch)
2014-05-05 15:53 PDT, Beth Dakin 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2014-05-05 14:54:32 PDT 
Need a delegate that informs the UI process when the page's pin state changes

<rdar://problem/16806231>
Comment 1 Beth Dakin 2014-05-05 15:22:28 PDT 
Created attachment 230859 [details]
Patch
Comment 2 Beth Dakin 2014-05-05 15:53:36 PDT 
Created attachment 230864 [details]
Patch that bumps version of UIClient

Thanks, Sam! Anders says I need to bump the version of the UIClient, so here is a new patch.
Comment 3 Anders Carlsson 2014-05-05 15:56:58 PDT 
Comment on attachment 230864 [details]
Patch that bumps version of UIClient

View in context: https://bugs.webkit.org/attachment.cgi?id=230864&action=review

> Source/WebKit2/UIProcess/API/APIUIClient.h:136
> +    virtual void pinnedStateDidChange(WebKit::WebPageProxy*) { }

This can take a WebPageProxy&.
Comment 4 Beth Dakin 2014-05-05 16:15:47 PDT 
(In reply to comment #3)
> (From update of attachment 230864 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230864&action=review
> 
> > Source/WebKit2/UIProcess/API/APIUIClient.h:136
> > +    virtual void pinnedStateDidChange(WebKit::WebPageProxy*) { }
> 
> This can take a WebPageProxy&.

I changed it to that! http://trac.webkit.org/changeset/168325