Bug 132582

Summary: Stop using BlobData on client side
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
with a debug assertion fix sam: review+

Alexey Proskuryakov
Reported 2014-05-05 14:50:03 PDT
BlobData has many data members that only make sense in BlobRegistryImpl, yet it's also used for blob registration on WebProcess side. This made us have some pretty nonsensical code.
Attachments
proposed patch (72.12 KB, patch)
2014-05-05 15:07 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
with a debug assertion fix (72.15 KB, patch)
2014-05-05 15:30 PDT, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-05-05 15:07:43 PDT
Created attachment 230857 [details] proposed patch Starting with EWS...
WebKit Commit Bot
Comment 2 2014-05-05 15:09:02 PDT
Attachment 230857 [details] did not pass style-queue: ERROR: Source/WebCore/fileapi/Blob.h:99: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/fileapi/Blob.h:102: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2014-05-05 15:30:50 PDT
Created attachment 230860 [details] with a debug assertion fix
WebKit Commit Bot
Comment 4 2014-05-05 15:32:26 PDT
Attachment 230860 [details] did not pass style-queue: ERROR: Source/WebCore/fileapi/Blob.h:99: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/WebCore/fileapi/Blob.h:102: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 5 2014-05-05 17:43:52 PDT
Committed <http://trac.webkit.org/r168333> (with a Windows fix).
Note You need to log in before you can comment on or make changes to this bug.