Bug 132582

Summary: Stop using BlobData on client side
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
with a debug assertion fix sam: review+

Description Alexey Proskuryakov 2014-05-05 14:50:03 PDT 
BlobData has many data members that only make sense in BlobRegistryImpl, yet it's also used for blob registration on WebProcess side. This made us have some pretty nonsensical code.
Comment 1 Alexey Proskuryakov 2014-05-05 15:07:43 PDT 
Created attachment 230857 [details]
proposed patch

Starting with EWS...
Comment 2 WebKit Commit Bot 2014-05-05 15:09:02 PDT 
Attachment 230857 [details] did not pass style-queue:


ERROR: Source/WebCore/fileapi/Blob.h:99:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/fileapi/Blob.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-05-05 15:30:50 PDT 
Created attachment 230860 [details]
with a debug assertion fix
Comment 4 WebKit Commit Bot 2014-05-05 15:32:26 PDT 
Attachment 230860 [details] did not pass style-queue:


ERROR: Source/WebCore/fileapi/Blob.h:99:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/fileapi/Blob.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alexey Proskuryakov 2014-05-05 17:43:52 PDT 
Committed <http://trac.webkit.org/r168333> (with a Windows fix).