Bug 132579

Summary:

Don't select an image that is about to have its menu shown.

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch v1	thorton: review+

Description Brady Eidson 2014-05-05 13:27:51 PDT

Don't select an image that is about to be serviced.

Instead select it afterwards and before pasting the result.

<rdar://problem/16807845>

Comment 1 Brady Eidson 2014-05-06 09:23:01 PDT

Created attachment 230911 [details]
Patch v1

Comment 2 Tim Horton 2014-05-06 12:07:42 PDT

Comment on attachment 230911 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=230911&action=review

> Source/WebCore/editing/mac/EditorMac.mm:272
> +    if (&(node->document()) != m_frame.document())

Don't think you need the parens.

> Source/WebKit/mac/ChangeLog:10
> +          Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.

extra space at the beginning of the line

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:125
> +    Node* node = page->contextMenuController().context().hitTestResult().innerNode();
> +    if (node) {

if (Node* node = ...)

Comment 3 Brady Eidson 2014-05-06 14:09:03 PDT

https://trac.webkit.org/r168378