| Summary: | Use a layer delegate instead of web_disableAllActions wherever possible | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | Layout and Rendering | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, mitz, sam, simon.fraser | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2014-05-05 02:06:09 PDT
Created attachment 230815 [details]
patch
Attachment 230815 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:35: Missing space before { [whitespace/braces] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:36: Missing space before { [whitespace/braces] [5]
Total errors found: 2 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230815 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230815&action=review > Source/WebCore/platform/graphics/cocoa/WebCALayerController.h:29 > +@interface WebCALayerController : NSObject I don't like the name; this class isn't a controller for layers. Maybe WebDefaultCALayerDelegate or something? |