Bug 132559

Summary:

[Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cgarcia: review+

Description Zan Dobersek 2014-05-04 23:49:28 PDT

[Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle

Comment 1 Zan Dobersek 2014-05-04 23:59:56 PDT

Created attachment 230809 [details]
Patch

Comment 2 Carlos Garcia Campos 2014-05-05 01:11:30 PDT

Comment on attachment 230809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230809&action=review

> Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:87
> -    , m_readBuffer(0)
> +    , m_readBuffer(nullptr)

Do we really need to initialize a std:unique_ptr? doesn't it set the internal pointer to 0 in its constructor?

> Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:102
> -    , m_readBuffer(0)
> +    , m_readBuffer(nullptr)

Ditto.

Comment 3 Carlos Garcia Campos 2014-05-05 01:12:03 PDT

Comment on attachment 230809 [details]
Patch

Forgot to change the flag :-P

Comment 4 Zan Dobersek 2014-05-05 23:20:35 PDT

Committed r168351: <http://trac.webkit.org/changeset/168351>