Summary: | [EFL][WK2] Refactor favicon database APIs | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryuan Choi
2014-05-02 22:45:55 PDT
Created attachment 230746 [details]
Patch
Comment on attachment 230746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230746&action=review > Source/WebKit2/ChangeLog:11 > + It's simple to use but it always adds the callback to EwkView although applications does not use favicon. I agree that we don't need to support two options to get favicon data. However, I don't think first option has big overhead to add favicon callback in application side. Anyway, I don't have pros to keep first way. So, r+ed. > Tools/ChangeLog:8 > + * MiniBrowser/efl/main.c: Use ewk_view_favicon_get instead of ewk_view_favicon_get. Use ewk_view_favicon_get instead of ewk_view_favicon_get. => Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get. ? > Tools/MiniBrowser/efl/main.c:327 > + Evas_Object* favicon = ewk_favicon_database_icon_get(database, url, evas_object_evas_get(ewk_view)); Looks wrong * place in Evas_Object* favicon Committed r168265: <http://trac.webkit.org/changeset/168265> |