| Summary: | Add Jeremy as a committer. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> | ||||
| Component: | New Bugs | Assignee: | Jeremy Jones <jeremyj-wk> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, glenn, jer.noble, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jeremy Jones
2014-05-02 14:57:22 PDT
Created attachment 230703 [details]
Patch
Attachment 230703 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230703 [details] Patch Rejecting attachment 230703 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 230703, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/common/config/contributors.json Hunk #1 succeeded at 1237 with fuzz 1 (offset 8 lines). Hunk #2 FAILED at 3041. 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/config/contributors.json.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5623722081779712 You shouldn't have landed this patch with commit queue as the style queue noticed it. The committer should land this addition manually. |