Bug 132489

Summary: [Mac] -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking a snapshot will always succeed
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit Misc.Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Mark Rowe (bdash) 2014-05-02 14:29:13 PDT 
The takeSnapshot callback in -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking the snapshot will always succeed. If it fails and the callback receives a null ShareableBitmap::Handle, as can happen if the WKView is closed while a snapshot request is pending, the callback will dereference null.
Comment 1 Mark Rowe (bdash) 2014-05-02 14:29:29 PDT 
<rdar://problem/16704660>
Comment 2 Mark Rowe (bdash) 2014-05-02 14:37:04 PDT 
Created attachment 230702 [details]
Patch
Comment 3 Mark Rowe (bdash) 2014-05-02 15:04:32 PDT 
Committed r168195: <http://trac.webkit.org/changeset/168195>