Summary: | Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem: | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2014-05-02 13:23:29 PDT
Created attachment 230690 [details]
Patch v1
Comment on attachment 230690 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373 > + Node* node = page->contextMenuController().context().hitTestResult().innerNode(); any reason to null check node? > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384 > + ASSERT_NOT_REACHED(); why this assert, and then a happy handling of it on the next line? (In reply to comment #2) > (From update of attachment 230690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review > > > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373 > > + Node* node = page->contextMenuController().context().hitTestResult().innerNode(); > > any reason to null check node? Good point. > > > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384 > > + ASSERT_NOT_REACHED(); > > why this assert, and then a happy handling of it on the next line? For the same reason we need to null check node - WebContextMenuClient handles all types of content menu invocations, including ones that are not about anything that deserves a rect or that have already rendered. |