Bug 132474

Summary:

REGRESSION (r168095): 1-pixel gap between adjacent selection inlines

Product:

WebKit

Reporter:

mitz

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, darin, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, hyatt, kondapallykalyan, krit, pdr, rniwa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

HasReduction, InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

data:text/html,<div>You%20can%20<span>select</span>%20this.</div>

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Patch	none
Patch	none
Patch	none
Patch	none

mitz

Reported 2014-05-02 11:32:50 PDT

To reproduce the bug, navigate to the URL and Select All.

Attachments
Patch (32.12 KB, patch) 2014-05-05 21:10 PDT, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (472.59 KB, application/zip) 2014-05-05 22:17 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (544.47 KB, application/zip) 2014-05-05 23:02 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (547.38 KB, application/zip) 2014-05-06 00:11 PDT, Build Bot	no flags	Details
Patch (40.32 KB, patch) 2014-05-07 13:00 PDT, alan	no flags	Details Formatted Diff Diff
Patch (43.67 KB, patch) 2014-05-07 16:03 PDT, alan	no flags	Details Formatted Diff Diff
Patch (43.93 KB, patch) 2014-05-07 20:13 PDT, alan	no flags	Details Formatted Diff Diff
Patch (44.02 KB, patch) 2014-05-08 20:11 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-05-02 11:33:40 PDT

<rdar://problem/16797394>

alan

Comment 2 2014-05-02 11:38:33 PDT

This is caused by the integral inline text positioning.

alan

Comment 3 2014-05-05 21:10:43 PDT

Created attachment 230884 [details] Patch

alan

Comment 4 2014-05-05 21:20:30 PDT

Now that directional snapping is removed from Font, adjustSelectionRectForText returns unsnapped coordinates, but they are either device pixel snapped (directional snapping) or enclosing integral snapped (no directional is needed there as rect is expanded in both directions.). -tracked here bug 132598

Build Bot

Comment 5 2014-05-05 22:17:37 PDT

Comment on attachment 230884 [details] Patch Attachment 230884 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6134904794382336 New failing tests: fast/block/line-layout/selection-highlight-overlap.html editing/selection/block-cursor-overtype-mode.html

Build Bot

Comment 6 2014-05-05 22:17:44 PDT

Created attachment 230887 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-05-05 23:02:25 PDT

Comment on attachment 230884 [details] Patch Attachment 230884 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5333962381590528 New failing tests: editing/selection/block-cursor-overtype-mode.html svg/text/caret-in-svg-text.xhtml fast/block/line-layout/selection-highlight-overlap.html editing/selection/mixed-editability-10.html fast/forms/cursor-at-editable-content-boundary.html platform/mac/editing/input/caret-primary-bidi.html

Build Bot

Comment 8 2014-05-05 23:02:33 PDT

Created attachment 230890 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-05-06 00:11:17 PDT

Comment on attachment 230884 [details] Patch Attachment 230884 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5873240354324480 New failing tests: editing/selection/block-cursor-overtype-mode.html svg/text/caret-in-svg-text.xhtml fast/block/line-layout/selection-highlight-overlap.html editing/selection/mixed-editability-10.html fast/forms/cursor-at-editable-content-boundary.html platform/mac/editing/input/caret-primary-bidi.html

Build Bot

Comment 10 2014-05-06 00:11:23 PDT

Created attachment 230891 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

alan

Comment 11 2014-05-07 13:00:48 PDT

Created attachment 231011 [details] Patch

alan

Comment 12 2014-05-07 16:03:52 PDT

Created attachment 231027 [details] Patch

alan

Comment 13 2014-05-07 20:13:20 PDT

Created attachment 231038 [details] Patch

Dave Hyatt

Comment 14 2014-05-08 13:31:56 PDT

Comment on attachment 231038 [details] Patch r=me

alan

Comment 15 2014-05-08 20:11:32 PDT

Created attachment 231124 [details] Patch

alan

Comment 16 2014-05-08 20:11:55 PDT

Comment on attachment 231124 [details] Patch EWSing

WebKit Commit Bot

Comment 17 2014-05-09 07:21:18 PDT

Comment on attachment 231124 [details] Patch Clearing flags on attachment: 231124 Committed r168528: <http://trac.webkit.org/changeset/168528>

WebKit Commit Bot

Comment 18 2014-05-09 07:21:27 PDT

All reviewed patches have been landed. Closing bug.

Dirk Schulze

Comment 19 2014-05-13 07:15:17 PDT

It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. Here is a short example: http://jsfiddle.net/9kj2M/ Try to select the text.

alan

Comment 20 2014-05-13 07:18:22 PDT

(In reply to comment #19) > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. > > Here is a short example: http://jsfiddle.net/9kj2M/ > > Try to select the text. Indeed. Looking into now.

alan

Comment 21 2014-05-13 07:43:22 PDT

(In reply to comment #20) > (In reply to comment #19) > > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. > > > > Here is a short example: http://jsfiddle.net/9kj2M/ > > > > Try to select the text. > Indeed. Looking into now.(In reply to comment #20) > (In reply to comment #19) > > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. > > > > Here is a short example: http://jsfiddle.net/9kj2M/ > > > > Try to select the text. > Indeed. Looking into now. Patch is coming up: bug 132868

Note You need to log in before you can comment on or make changes to this bug.