| Summary: | REGRESSION (r168095): 1-pixel gap between adjacent selection inlines | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, darin, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, hyatt, kondapallykalyan, krit, pdr, rniwa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||
| Priority: | P1 | Keywords: | HasReduction, InRadar, Regression | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| URL: | data:text/html,<div>You%20can%20<span>select</span>%20this.</div> | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
mitz
2014-05-02 11:32:50 PDT
This is caused by the integral inline text positioning. Created attachment 230884 [details]
Patch
Now that directional snapping is removed from Font, adjustSelectionRectForText returns unsnapped coordinates, but they are either device pixel snapped (directional snapping) or enclosing integral snapped (no directional is needed there as rect is expanded in both directions.). -tracked here bug 132598 Comment on attachment 230884 [details] Patch Attachment 230884 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6134904794382336 New failing tests: fast/block/line-layout/selection-highlight-overlap.html editing/selection/block-cursor-overtype-mode.html Created attachment 230887 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 230884 [details] Patch Attachment 230884 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5333962381590528 New failing tests: editing/selection/block-cursor-overtype-mode.html svg/text/caret-in-svg-text.xhtml fast/block/line-layout/selection-highlight-overlap.html editing/selection/mixed-editability-10.html fast/forms/cursor-at-editable-content-boundary.html platform/mac/editing/input/caret-primary-bidi.html Created attachment 230890 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 230884 [details] Patch Attachment 230884 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5873240354324480 New failing tests: editing/selection/block-cursor-overtype-mode.html svg/text/caret-in-svg-text.xhtml fast/block/line-layout/selection-highlight-overlap.html editing/selection/mixed-editability-10.html fast/forms/cursor-at-editable-content-boundary.html platform/mac/editing/input/caret-primary-bidi.html Created attachment 230891 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 231011 [details]
Patch
Created attachment 231027 [details]
Patch
Created attachment 231038 [details]
Patch
Comment on attachment 231038 [details]
Patch
r=me
Created attachment 231124 [details]
Patch
Comment on attachment 231124 [details]
Patch
EWSing
Comment on attachment 231124 [details] Patch Clearing flags on attachment: 231124 Committed r168528: <http://trac.webkit.org/changeset/168528> All reviewed patches have been landed. Closing bug. It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. Here is a short example: http://jsfiddle.net/9kj2M/ Try to select the text. (In reply to comment #19) > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. > > Here is a short example: http://jsfiddle.net/9kj2M/ > > Try to select the text. Indeed. Looking into now. (In reply to comment #20) > (In reply to comment #19) > > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. > > > > Here is a short example: http://jsfiddle.net/9kj2M/ > > > > Try to select the text. > Indeed. Looking into now.(In reply to comment #20) > (In reply to comment #19) > > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595. > > > > Here is a short example: http://jsfiddle.net/9kj2M/ > > > > Try to select the text. > Indeed. Looking into now. Patch is coming up: bug 132868 |