| Summary: | [Mac] Allow MediaPlayerPrivate to control object-fit via videoGravity. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, jonlee, kondapallykalyan, philipj, rniwa, sergio, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2014-05-01 22:05:54 PDT
Created attachment 230652 [details]
Patch
Comment on attachment 230652 [details] Patch Attachment 230652 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5727633446797312 New failing tests: media/video-poster-background.html Created attachment 230654 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 230652 [details] Patch Attachment 230652 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6486378074341376 New failing tests: media/video-poster-background.html Created attachment 230662 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 230652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230652&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:437 > - [m_synchronizer setRate:(m_playing ? m_rate : 0) time:toCMTime(seekTime)]; > + [m_synchronizer setRate:0]; > + [m_synchronizer setRate:0 time:toCMTime(seekTime)]; Is this supposed to be part of the same patch? (In reply to comment #6) > (From update of attachment 230652 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230652&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:437 > > - [m_synchronizer setRate:(m_playing ? m_rate : 0) time:toCMTime(seekTime)]; > > + [m_synchronizer setRate:0]; > > + [m_synchronizer setRate:0 time:toCMTime(seekTime)]; > > Is this supposed to be part of the same patch? Whoops, no. I'll post a new patch with a win port fix and without this diff. Comment on attachment 230652 [details]
Patch
Patch is too old to apply cleanly, and caused a number of tests to fail. Can you please update against current sources and fix the test failures?
|