Bug 132448

Summary: Support OS-version-specific install paths for WebKit.framework
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Anders Carlsson
Reported 2014-05-01 16:09:55 PDT
Support OS-version-specific install paths for WebKit.framework
Attachments
Patch (5.50 KB, patch)
2014-05-01 16:14 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (4.84 KB, patch)
2014-05-01 17:25 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-05-01 16:14:13 PDT
Created attachment 230623 [details] Patch
Anders Carlsson
Comment 2 2014-05-01 17:25:34 PDT
Created attachment 230631 [details] Patch
WebKit Commit Bot
Comment 3 2014-05-01 17:27:59 PDT
Attachment 230631 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebKitLegacy/WebKit.m:33: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 4 2014-05-01 17:29:33 PDT
Comment on attachment 230631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230631&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:2147 > + runOnlyForDeploymentPostprocessing = 0; This should be 1, and you can skip the SKIP_INSTALL test below.
Anders Carlsson
Comment 5 2014-05-01 17:34:34 PDT
Committed r168138: <http://trac.webkit.org/changeset/168138>
Note You need to log in before you can comment on or make changes to this bug.