|Summary:||Move size computation for Blob constructor into BlobRegistryImpl|
|Product:||WebKit||Reporter:||Alexey Proskuryakov <ap>|
|Component:||WebCore Misc.||Assignee:||Alexey Proskuryakov <ap>|
|Version:||528+ (Nightly build)|
Description Alexey Proskuryakov 2014-05-01 14:15:45 PDT
Blob constructor takes several blobs and combines them into one. We should do more of that in the registry, where the knowledge of the actual data is.
Comment 1 Alexey Proskuryakov 2014-05-01 14:31:44 PDT
Created attachment 230609 [details] proposed patch
Comment 2 WebKit Commit Bot 2014-05-01 14:33:40 PDT
Attachment 230609 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:143: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero]  Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-05-01 15:30:41 PDT
Created attachment 230617 [details] patch for landing With build and threading fixes (forgot to add a semaphore).
Comment 4 WebKit Commit Bot 2014-05-01 16:09:58 PDT
Comment on attachment 230617 [details] patch for landing Clearing flags on attachment: 230617 Committed r168126: <http://trac.webkit.org/changeset/168126>
Comment 5 WebKit Commit Bot 2014-05-01 16:10:01 PDT
All reviewed patches have been landed. Closing bug.