Bug 132435

Summary:

[iOS][WK2] The highlight view needs to be in WKWebView coordinates

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2014-05-01 12:36:43 PDT

[iOS][WK2] The highlight view needs to be in WKWebView coordinates

Comment 1 Benjamin Poulain 2014-05-01 12:40:32 PDT

Created attachment 230603 [details]
Patch

Comment 2 Tim Horton 2014-05-01 13:25:53 PDT

Comment on attachment 230603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230603&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:375
> +        RetainPtr<UIColor> highlightUIKitColor = adoptNS([[UIColor alloc] initWithRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)]);

We really need something for this in Color or somewhere.

Comment 3 Benjamin Poulain 2014-05-01 13:33:20 PDT

Comment on attachment 230603 [details]
Patch

Clearing flags on attachment: 230603

Committed r168117: <http://trac.webkit.org/changeset/168117>

Comment 4 Benjamin Poulain 2014-05-01 13:33:22 PDT

All reviewed patches have been landed.  Closing bug.