Bug 132403

Summary:

Always-visible scrollbars continuously repaint after non-momentum scrollling

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, bdakin, cmarcelo, commit-queue, jamesr, luiz, simon.fraser, thorton, tonikitoo

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Beth Dakin 2014-04-30 14:25:00 PDT

Always-visible scrollbars continuously repaint after non-momentum scrolling

<rdar://problem/16553878>

Comment 1 Beth Dakin 2014-04-30 14:29:05 PDT

Created attachment 230522 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-04-30 14:47:04 PDT

Comment on attachment 230522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230522&action=review

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:143
> +        if (m_verticalScrollbarPainter)
> +            [m_verticalScrollbarPainter setUsePresentationValue:YES];
> +        if (m_horizontalScrollbarPainter)
> +            [m_horizontalScrollbarPainter setUsePresentationValue:YES];

You don't really need the nil checks (messaging nil is OK).

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:378
> +        if (m_verticalScrollbarPainter && [m_verticalScrollbarPainter shouldUsePresentationValue]) {

Could just be if ([m_verticalScrollbarPainter shouldUsePresentationValue])

> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:385
> +        if (m_horizontalScrollbarPainter && [m_horizontalScrollbarPainter shouldUsePresentationValue]) {

Ditto.

Comment 3 Beth Dakin 2014-04-30 15:06:14 PDT

Fixed! Thanks, Simon!

http://trac.webkit.org/changeset/168049