Bug 132401

Summary: Move Source/WebCore/workers/ code to std::unique_ptr
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Severity: Normal CC: clopez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 132789    
Bug Blocks: 128007    
Description Flags
Patch none

Description Zan Dobersek 2014-04-30 14:12:09 PDT
Move Source/WebCore/workers/ code to std::unique_ptr
Comment 1 Zan Dobersek 2014-04-30 14:14:08 PDT
Created attachment 230519 [details]
Comment 2 Zan Dobersek 2014-05-10 12:14:53 PDT
Comment on attachment 230519 [details]

Clearing flags on attachment: 230519

Committed r168578: <http://trac.webkit.org/changeset/168578>
Comment 3 Zan Dobersek 2014-05-10 12:14:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Commit Bot 2014-05-10 15:40:14 PDT
Re-opened since this is blocked by bug 132789
Comment 5 Carlos Alberto Lopez Perez 2014-05-10 17:02:24 PDT
Looks like this caused failures on the layout tests of the GTK Debug build.

r168577 -> layout-test 71 failures 16 new passes 40 flakes http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/47
r168578 -> layout-test Exiting early after 24 crashes and 26 timeouts. 31383 tests run. 121 failures 15 new passes  -> http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/48
Comment 6 Zan Dobersek 2014-05-11 05:26:22 PDT
Created attachment 231260 [details]
Comment 7 Zan Dobersek 2014-05-11 05:30:05 PDT
(In reply to comment #6)
> Created an attachment (id=231260) [details]
> Patch

Avoids leaking a ScheduledAction object, fixing the layout tests in debug builds.

Can't confirm the same effect on the Apple-internal PLT3, for obvious reasons.
Comment 8 Zan Dobersek 2014-05-11 12:11:11 PDT
Comment on attachment 231260 [details]

Clearing flags on attachment: 231260

Committed r168600: <http://trac.webkit.org/changeset/168600>
Comment 9 Zan Dobersek 2014-05-11 12:11:19 PDT
All reviewed patches have been landed.  Closing bug.