| Summary: | Move Source/WebCore/workers/ code to std::unique_ptr | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | clopez, commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 132789 | ||||||||
| Bug Blocks: | 128007 | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2014-04-30 14:12:09 PDT
Created attachment 230519 [details]
Patch
Comment on attachment 230519 [details] Patch Clearing flags on attachment: 230519 Committed r168578: <http://trac.webkit.org/changeset/168578> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 132789 Looks like this caused failures on the layout tests of the GTK Debug build. r168577 -> layout-test 71 failures 16 new passes 40 flakes http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/47 r168578 -> layout-test Exiting early after 24 crashes and 26 timeouts. 31383 tests run. 121 failures 15 new passes -> http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/48 Created attachment 231260 [details]
Patch
(In reply to comment #6) > Created an attachment (id=231260) [details] > Patch Avoids leaking a ScheduledAction object, fixing the layout tests in debug builds. Can't confirm the same effect on the Apple-internal PLT3, for obvious reasons. Comment on attachment 231260 [details] Patch Clearing flags on attachment: 231260 Committed r168600: <http://trac.webkit.org/changeset/168600> All reviewed patches have been landed. Closing bug. |