| Summary: | [CSS Grid Layout] Remove runtime feature | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
| Component: | CSS | Assignee: | Manuel Rego Casasnovas <rego> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, berto, bunhere, cdumez, cgarcia, commit-queue, esprehn+autocc, glenn, gustavo, gyuyoung.kim, jfernandez, kangil.han, macpherson, menard, mrobinson, rniwa, sergio, svillar, syoichi | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 60731 | ||||||||
| Attachments: |
|
||||||||
|
Description
Manuel Rego Casasnovas
2014-04-30 08:16:44 PDT
Created attachment 230478 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 230478 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230478&action=review That's actually a quite nice cleanup. > Source/WebCore/WebCore.order:-4327 > -__ZNK7WebCore8Document20cssGridLayoutEnabledEv You actually don't need to update the order files, we update them ourself from the binary before releasing. Comment on attachment 230478 [details] Patch Rejecting attachment 230478 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 230478, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ss3/grid/grid-column-002.htm patching file LayoutTests/ietestcenter/css3/grid/testRunnerEnableGrid.js rm 'LayoutTests/ietestcenter/css3/grid/testRunnerEnableGrid.js' patching file PerformanceTests/ChangeLog patching file PerformanceTests/Layout/auto-grid-lots-of-data.html patching file PerformanceTests/Layout/fixed-grid-lots-of-data.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Benjamin Poulain']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5260031767347200 Created attachment 230977 [details]
Rebased patch.
Comment on attachment 230977 [details] Rebased patch. Clearing flags on attachment: 230977 Committed r168416: <http://trac.webkit.org/changeset/168416> All reviewed patches have been landed. Closing bug. |