Bug 132374

Summary: [iOS] do not pause video when entering background while playing to external device
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, calvaris, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Updated patch.
jer.noble: review+
Another patch none

Eric Carlson
Reported 2014-04-29 20:41:23 PDT
Do not pause <video>/<audio> when process switches to background while playing to an external device.
Attachments
Proposed patch. (11.57 KB, patch)
2014-04-29 20:50 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Updated patch. (11.56 KB, patch)
2014-04-30 09:51 PDT, Eric Carlson 		jer.noble: review+
DetailsFormatted DiffDiff
Another patch (12.92 KB, patch)
2014-04-30 15:09 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-04-29 20:41:56 PDT
<rdar://problem/16630465>
Eric Carlson
Comment 2 2014-04-29 20:50:18 PDT
Created attachment 230454 [details] Proposed patch.
Eric Carlson
Comment 3 2014-04-30 09:51:56 PDT
Created attachment 230485 [details] Updated patch.
Jer Noble
Comment 4 2014-04-30 14:44:46 PDT
Comment on attachment 230485 [details] Updated patch. View in context: https://bugs.webkit.org/attachment.cgi?id=230485&action=review > Source/WebCore/platform/audio/MediaSession.cpp:85 > + if (type == EnteringBackground && client().overrideBackgroundPlaybackRestriction()) > + return; > + I'm not a huge fan of making the client responsible for this behavior, but I don't think we have a choice right now. r=me.
Eric Carlson
Comment 5 2014-04-30 15:09:39 PDT
Created attachment 230528 [details] Another patch To get the managed name of beginInterruption for the Windows export file.
Eric Carlson
Comment 6 2014-04-30 18:48:52 PDT
Committed r168075: https://trac.webkit.org/r168075
Ahmad Saleem
Comment 7 2022-10-25 15:28:26 PDT
Landed and didn't backed out - https://github.com/WebKit/WebKit/commit/3b125a6bb5d73e88f35bb8c07e843997c3ac35e9 Marking this as "RESOLVED FIXED".
Note You need to log in before you can comment on or make changes to this bug.