| Summary: | update angle | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||||||||||
| Component: | ANGLE | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | bunhere, commit-queue, dino, eric.carlson, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, noam, philipj, rakuco, roger_fong, sergio | ||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Alex Christensen
2014-04-29 16:30:42 PDT
Created attachment 230443 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 230443 [details] Patch I forgot Roger's changes from https://bugs.webkit.org/show_bug.cgi?id=125124 Created attachment 230484 [details]
Patch
Created attachment 230486 [details]
Patch
Created attachment 230487 [details]
Patch
Created attachment 230490 [details]
patch
Created attachment 230496 [details]
patch
Created attachment 230497 [details]
patch
Created attachment 230502 [details]
patch
Created attachment 230505 [details]
patch
Created attachment 230510 [details]
patch
Writing comments here because the review tool is unhappy with me: - Please add a link to <rdar://problem/16211451> in the changelog - Don't remove <array> in the plist. That file is used by some automatic process in Apple's system (I don't know how), so we can't change the format This also needs the WebKit-specific changes made in http://trac.webkit.org/changeset/164580 Lastly, please confirm that http://trac.webkit.org/changeset/160199 is now covered in the updated code. Created attachment 230518 [details]
patch
(In reply to comment #13) > Writing comments here because the review tool is unhappy with me: > > - Please add a link to <rdar://problem/16211451> in the changelog Done. > - Don't remove <array> in the plist. That file is used by some automatic process in Apple's system (I don't know how), so we can't change the format Fixed. > > This also needs the WebKit-specific changes made in http://trac.webkit.org/changeset/164580 ANGLE has made some changes to src/libGLESv2/Program.cpp so I adapted to their changes. My changes can be seen in changes.diff. No WebKit ports are using that file right now, though, so it shouldn't change anything. > > Lastly, please confirm that http://trac.webkit.org/changeset/160199 is now covered in the updated code. It already was. Comment on attachment 230518 [details] patch Rejecting attachment 230518 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 230518, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e921d3d8e646e3b38c54c29ffa38d4d5708 r168046 = 860937fc8fe1f954dcd824171c859fbafa1176c2 r168047 = 2201dc7ef9dfc80fe6ae593eafd6c68f590c674b r168048 = db1671a2aa4338701457b6f2445c6230c72ae2da r168049 = 199e402b648e7bf69927624b7c76a5a92bf90ed6 r168050 = df40d6e0f374ac7e4269537464c26e066023161b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/5069287706329088 |