Bug 132353

Summary: Remove some PLATFORM(IOS) #ifdefs related to hasAcceleratedTouchScrolling()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Description Simon Fraser (smfr) 2014-04-29 14:20:58 PDT
Remove some PLATFORM(IOS) #ifdefs related to hasAcceleratedTouchScrolling()
Comment 1 Simon Fraser (smfr) 2014-04-29 14:24:09 PDT
Created attachment 230418 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-29 14:26:51 PDT
Attachment 230418 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:406:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-04-29 15:09:53 PDT
Created attachment 230427 [details]
Patch
Comment 4 WebKit Commit Bot 2014-04-29 15:12:21 PDT
Attachment 230427 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:406:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Darin Adler 2014-04-29 15:56:02 PDT
Comment on attachment 230427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230427&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:-412
> -// FIXME: We should merge the concept of RenderLayer::{hasAcceleratedTouchScrolling, needsCompositedScrolling}()
> -// so that we can remove this iOS-specific variant.

Don’t we still want something like this FIXME?

> Source/WebCore/rendering/RenderLayerBacking.cpp:443
> +    return (style.transformOriginX().type() == Fixed && style.transformOriginX().value())
> +        || (style.transformOriginY().type() == Fixed && style.transformOriginY().value());

I don’t think we need these parentheses.
Comment 6 Simon Fraser (smfr) 2014-04-29 16:54:50 PDT
https://trac.webkit.org/r167970