Bug 132353 – Remove some PLATFORM(IOS) #ifdefs related to hasAcceleratedTouchScrolling()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Remove some PLATFORM(IOS) #ifdefs related to hasAcceleratedTouchScrolling()

[Simon Fraser (smfr)]

Created attachment 230418 [details]
Patch

[WebKit Commit Bot]

Attachment 230418 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:406:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 230427 [details]
Patch

[WebKit Commit Bot]

Attachment 230427 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayerBacking.cpp:406:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 230427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230427&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:-412
> -// FIXME: We should merge the concept of RenderLayer::{hasAcceleratedTouchScrolling, needsCompositedScrolling}()
> -// so that we can remove this iOS-specific variant.

Don’t we still want something like this FIXME?

> Source/WebCore/rendering/RenderLayerBacking.cpp:443
> +    return (style.transformOriginX().type() == Fixed && style.transformOriginX().value())
> +        || (style.transformOriginY().type() == Fixed && style.transformOriginY().value());

I don’t think we need these parentheses.

[Simon Fraser (smfr)]

https://trac.webkit.org/r167970