Bug 132331 – Build warning in source/JavaScriptCore/dfg/DFGFixupPhase.cpp

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Tanay]

In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h: In member function ‘void JSC::DFG::FixupPhase::injectTypeConversionsForEdge(JSC::DFG::Node*, JSC::DFG::Edge&)’:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized]
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1898:19: note: ‘result’ was declared here
In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h: In member function ‘void JSC::DFG::FixupPhase::injectTypeConversionsInBlock(JSC::DFG::BasicBlock*)’:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized]
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1898:19: note: ‘result’ was declared here
In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized]

[Tanay]

Created attachment 230889 [details]
Patch for build warning fix

Patch to Fix build warning and coding style warning in DFGFixupPhase.cpp

[Filip Pizlo]

Comment on attachment 230889 [details]
Patch for build warning fix

Looks like you need to rebase.

[Tanay]

(In reply to comment #2)
> (From update of attachment 230889 [details])
> Looks like you need to rebase.
 
Rebased to r168352. Can still see the warning. Could you please let me know if I am missing some information?

[Filip Pizlo]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 230889 [details] [details])
> > Looks like you need to rebase.
> 
> Rebased to r168352. Can still see the warning. Could you please let me know if I am missing some information?

What I mean is, can you upload a debased patch?

[Tanay]

Created attachment 230990 [details]
Patch

[Filip Pizlo]

Comment on attachment 230990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230990&action=review

> Source/JavaScriptCore/ChangeLog:93
> +>>>>>>> .r168416

You should remove the conflict markets.

[Tanay]

Created attachment 231046 [details]
Patch

[Darin Adler]

Comment on attachment 231046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231046&action=review

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1868
> +        Node* result = 0;

Please use nullptr instead of 0.

[Tanay]

Created attachment 231130 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 231130 [details]
Patch

Clearing flags on attachment: 231130

Committed r168540: <http://trac.webkit.org/changeset/168540>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.